Add WASM support - #1285
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
869964a to
6aca7ee
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
d3534d6 to
59bd9b6
Compare
59bd9b6 to
df5a05f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit df5a05f. Configure here.
| ..Default::default() | ||
| } | ||
| .into(), | ||
| ) |
There was a problem hiding this comment.
WASM cfg overly broad
Medium Severity
server_name and os_context gate on target_arch = "wasm32", which also matches targets like Emscripten where uname/hostname and real OS info previously worked. That regresses those targets to a hardcoded "WASM" OS and no server name. sentry-time already uses the narrower wasm + unknown cfg for browser-only limitations.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit df5a05f. Configure here.
|
Hey @darrell-roberts 👋 I would like to reiterate our position from the previous discussion in #226 and my follow-up on #1100. As I explained on #1100, that PR was intentionally kept closed because we do not currently have the capacity to review this work. Since this PR covers substantially the same feature, I am going to close it as well. More generally, adding WASM support affects several core parts of the SDK. We want to ensure that the resulting implementation is something we can maintain and support, so we plan to investigate, design, and implement a solution ourselves. We are therefore not accepting external PRs for WASM support, so please refrain from opening any further WASM-support PRs. Thanks again for your interest and for sharing your work 🙏 |
2 participants
Description
The SDK today can not be used with WASM targets. These changes work for my current utilization of the SDK but there are other things that need to change. The transport for example. I have a custom transport for our needs along with a WASM transport. I can add the WASM transport to this PR but for now I'd like to submit this to get started on the discussion/work to get WASM support in the SDK.
Issues